QGIS » QGIS Application

In QgsVectorLayer::updateFeature, when updating a record that contains 2 geometries, after the record has been created with the first geometry,
the second cannot be updated with a valid geometry since the 'current' returns hasGeometry() == 0.

  QgsFeature currentFeature = getFeature( updatedFeature.id() );
  if ( currentFeature.isValid() )
  {
    QgsDebugMsg( QString( "feature %1 could not be retrieved" ).arg( updatedFeature.id() ) );
    if ( updatedFeature.hasGeometry() && currentFeature.hasGeometry() && !updatedFeature.geometry().isGeosEqual( currentFeature.geometry() ) )
    {
     ...
    }
  }

The check for && currentFeature.hasGeometry() should be removed

• updating a NULL geometry with a valid new geometry should be allowed

The current QgsDebugMsg is also misleading, since currentFeature.isValid() is true

• this is a leftover from changes made to return when the record could not be retrieved
• this message should occur as the else of the isValid() statement.

  QgsFeature currentFeature = getFeature( updatedFeature.id() );
  if ( currentFeature.isValid() )
  {
    QgsDebugMsg( QString( "feature %1 could was retrieved updatedFeature.hasGeometry[%2] currentFeature.hasGeometry[%3]" ).arg( updatedFeature.id() ).arg(updatedFeature.hasGeometry()).arg(currentFeature.hasGeometry()) );
    if ( updatedFeature.hasGeometry() && !updatedFeature.geometry().isGeosEqual( currentFeature.geometry() ) )
    {
     ...
    }
  }
  else
  {
    QgsDebugMsg( QString( "feature %1 could not be retrieved" ).arg( updatedFeature.id() ) );
  }