Bug report #8567: SLD : an invalid sld is generated when exporting a polygon with fill styles - QGIS Application - QGIS Issue Tracking

Bug report #8567

SLD : an invalid sld is generated when exporting a polygon with fill styles

Added by Yewondwossen Assefa about 11 years ago. Updated about 11 years ago.

Status:	Closed
Priority:	Normal
Assignee:	-
Category:	Symbology
Affected QGIS version:	master	Regression?:	No
Operating System:		Easy fix?:	No
Pull Request or Patch supplied:	Yes	Resolution:	fixed
Crashes QGIS or corrupts data:	No	Copied to github as #:	17313

Description

This was initially reported on the mailing list:
- http://lists.osgeo.org/pipermail/qgis-user/2013-August/023650.html
- http://lists.osgeo.org/pipermail/qgis-developer/2013-August/028011.html

The sld produced is invalid at the GraphicFill level:

<se:GraphicFill>
<se:Graphic/>
<se:Mark>
<se:WellKnownName>x</se:WellKnownName>
<se:Stroke>
<se:SvgParameter name="stroke">#0000ff</se:SvgParameter>
</se:Stroke>
</se:Mark>
</se:GraphicFill>

The Mark element sould be a child of the <se:Graphic> element and not <se:GraphicFill>:
<se:GraphicFill>
<se:Graphic>
<se:Mark>
<se:WellKnownName>x</se:WellKnownName>
<se:Stroke>
<se:SvgParameter name="stroke">#0000ff</se:SvgParameter>
</se:Stroke>
</se:Mark>
</se:Graphic>
</se:GraphicFill>

The error comes from file ./src/core/symbology-ng/qgssymbollayerv2utils.cpp QgsSymbolLayerV2Utils::fillToSld (around line 1523).
Attached is the diff to correct it. This has been tested locally and gives the expected result.

qgis_sld_error.diff - git diff for the fix (774 Bytes) Yewondwossen Assefa, 2013-09-03 09:17 AM