Bug report #7628
undo while digitizing show wrong geometry of rubberband
Status: | Closed | ||
---|---|---|---|
Priority: | Normal | ||
Assignee: | - | ||
Category: | - | ||
Affected QGIS version: | master | Regression?: | No |
Operating System: | Easy fix?: | No | |
Pull Request or Patch supplied: | No | Resolution: | |
Crashes QGIS or corrupts data: | No | Copied to github as #: | 16551 |
Description
While you are digitizing/editing a line or polygon, it is possible to undo the last click in your line or polygon by using the DELETE or BACKSPACE key.
At this moment you see the red temporary object (which is a rubberband item) change, but counter intuitive. As soon as you move the mouse it is ok, but that is because the rubberband is repainted the right way then.
Try out:
Create a polygon with 4 vertices, and put your mouse somewhere in the middle of the square.
Now hit DELETE or BACKSPACE. You will see your square.
Now hit right mouse to stop editing. While the ending polygon is ok, the temporary geometry was wrong.
The problem is that in the qgsrubberband.removeLastPoint method actually removes the last point, which is actually not what you want if you are undoing a rubberband edit. I think you want to remove the point before the last one. In that case the rubberband stays intact and is more intuitive.
I'll attach a patch + pull request to show
Associated revisions
History
#1 Updated by Richard Duivenvoorde over 11 years ago
#2 Updated by Richard Duivenvoorde over 11 years ago
#3 Updated by Matthias Kuhn over 11 years ago
- Status changed from Open to Closed
Fixed in changeset bfef00a64457ac2715daaa4e5e55579f7282c693.