QGIS » QGIS Application

Yes, it's a regression. QGIS <= 1.7 used to warn at exit, if there were any unsaved changes in layers (I mean the layer contents. The unsaved project warning works ok). Now it exits quietly, losing the changes.

Note that when removing a layer from the TOC, the warning works ok.

Seems this caused by 8d4a656e4d (author Tim). As I understand, the reason to not emit signal is performance improvement. Here is small patch that should fix this.

Alexander Bruy wrote:

Seems this caused by 8d4a656e4d (author Tim). As I understand, the reason to not emit signal is performance improvement. Here is small patch that should fix this.

Hi Alexander, maybe is better to make a pull request on github... it will have more chances to have the patch added upstream as soon as possible.

Better implementation here:

https://github.com/qgis/Quantum-GIS/pull/334

Should be fixed (regarding layer edits) with commit 21370d9

Attached is warning shown on project close if there are unsaved provider edits.

It does not address the layer legend edit issue (needs different ticket?), but does address the original issue concern.

Hi Régis,

regis Haubourg wrote:

... Is there a way to open dialogs to save edits of all layers being edited? (this is the most common behaviour in other softs).

I think this would be handy, but a bit redundant. The layers are already listed in the legend with an edit icon. Other GUI items, like the layer's edit undo stack are already available in the main interface. Even if the dialog was more robust (offering saving of edited layers), I envision users looking at a layer listing and not remembering what they were editing, then cancelling the dialog to get back to the main interface to refresh their memory about the state of their edits (I know I do). I think just a more prominent warning and layer listing is all that is needed for now.

Ideally, having the legend layer's icon shift to a different version, or have the layer's text turn a different color, to indicate a layer has unsaved edits, would be helpful (not just for after cancelling project close prompt).

If not, I would just put warning red line in first position, and then propose a "Save project anyway?" on top of the three standars buttons.)

I have reformatted the notification and made it a separate dialog presented just before project save dialog (so as not to be confused with it). It also shows a layer listing in the same order as the legend to help understand which layers are affected, in case they are hidden in collapsed groups. See unsaved-provider-edits_2.png

If a user ignores the new dialog's WARNING, and loses edits... IMHO, they will learn to read such a dialog in the future. It no longer looks like the project close dialog and is very straightforward.

Caveat (or feature): there are now sometimes two dialogs to click through to close the project. While occasionally annoying, having project close dialog come after the 'layer edits exist' notification reduces the chance of the user accidentally/quickly clicking to dismiss a single dialog, thereby protecting against layer editing loss. Though, there are still times where the layer edits don't trigger a dirty project and the 'layer edits exist' notification dialog is the only one.

Note: not committed yet.

The current fix addresses the issue, but I am currently working on an integrated dialog to allow saving the unsaved edits, closing the project, or both (not a two-dialog approach as previously noted).

However, that is an additional feature beyond fixing this issue, so I'm closing the issue. Please reopen if needed.