QGIS » QGIS Application

Since the new symbology engine will be the default in 1.7, I think devs should look at this lost of feature from old to new symbology. I've attached screenshots (old engine, new engine, and one map example) in case my description above was unclear.

The patch has been added above. Can anyone please kindly review the patch and if you have any comments let me know , I will soon work on your comments and try to resolve that ?. Thanks .

Thanks Sunil; I'm not someone who can review the patch, but it seems to work well :)

I find that I can switch a layer from old symbology to new symbology successfully, but not back again. The patch could be improved slightly by allowing it to switch back, but I think this is a very minor issue (probably not worth the effort to fix) if old symbology is to be removed from QGIS soon.

e.g.

- select the first point symbol (circle) in old symbology, set the fill options to "None", Apply

- switch to new symbology and Apply - the markers should stay the same (apart from outline width, which is #3458)

- switch to old symbology - the markers will now have a solid fill

Also, I'm pretty sure this part of your patch breaks the dialogue somewhat:

-  connect( spinAngle, SIGNAL( valueChanged( double ) ), this, SLOT( setAngle() ) );

I'm guessing you actually meant to delete the line above that, as it is the same as the line the patch adds below, so the same line will appear twice if the patch is used.

Replying to [comment:9 Alister]:

I'm guessing you actually meant to delete the line above that, as it is the same as the line the patch adds below, so the same line will appear twice if the patch is used.

Thanks for reviewing the patch. Yes you are right I have done mistake while patching. I have attached a new patch can you please kindly review this one also ?

Hmmm. I didn't realise transparency wasn't working. I'm guessing uncommenting this in the new patch was supposed to fix it:

// selColor.setAlphaF( context.alpha() );

Like I say, I can't "review" the patch as I have almost no knowledge of C++, QT or the internals of QGIS.

I've noticed another thing that could be improved though: when you select a feature, the fill style is not applied to it.

see attached screenshot:

- fill style is not applied to selected features (actually, it looks like selected points are rendered by simply filling each symbol layer with yellow, so if transparency is applied the yellow is darker where two symbol layers overlap). I don't think this is a significant problem.

- transparency is only applied to borders, not fills.

- transparency is only applied to borders, not fills.

But it is applied to the yellow fill for selected features, as you can see :)

.

.

Ah - there's a preview button! I should use it ;)
-----------

- fill style is not applied to selected features (actually, it looks like selected points are rendered by simply filling each symbol layer with yellow, so if transparency is applied the yellow is darker where two symbol layers overlap). I don't think this is a significant problem.

- transparency is only applied to borders, not fills.

OK, that was easier than I expected. I've had a look at it, and fixed those things, and also what I'm pretty sure was a pre-existing mistake in this line:

QColor selPenColor = selBrushColor == mColor ? selBrushColor : mBorderColor;

I had to tidy/rearrange that section of code so I could understand it :)

I added a number of comments, mostly about inconsistencies compared with how QGIS renders polygon layers. Can someone else look at these and tell me what they think?

There is one reasonably annoying bug:

//"no fill" doesn't work if brushColor = penColor 
// e.g. if the symbol is a circle, the whole bounding box (is that what  it's called?)
// of the circle is filled.

I'm guessing to fix this an if statement is required something like the one I commented out because that method didn't work. But I don't know what to put in it!

Oh, yeah - I noticed another problem.

In the symbol layers box with these patches it only shows the fill, whereas it used to show a preview of the symbol layer.

//"no fill" doesn't work if brushColor = penColor

// e.g. if the symbol is a circle, the whole bounding box (is that what it's called?)

// of the circle is filled.

Actually, this isn't quite right. It definitely happens sometimes with no fill, but I can't figure out exactly when... it looks like it is something to do with the order in which I change the settings or something odd like that.

Oh, of course.

We shouldn't apply the fill style to selected features unless either we have a special pen colour for selected features (personally I think this would be nice), or we check to make sure the fill style isn't "no fill".

If the fill style is "no fill" and we apply it to selected features, then they look the same as unselected features :)

Oh, and I think I was wrong about this:

// Alister - I don't understand the reasoning for the following line
//  QColor selPenColor = selBrushColor == mColor ? selBrushColor : mBorderColor;
// I think it is a mistake and is meant to be this
  QColor selPenColor = mBorderColor == mColor ? selBrushColor : mBorderColor ;

This wouldn't have been a mistake - it is trying to make the selection look different if the symbol fill is the same colour as the selection fill. But there are still things that could be improved here: it won't achieve anything if the symbol fill and the symbol outline are both the same colour as the selection fill. Also, polygon layers aren't dealt with in the same way, and they probably should be.

Oh, yeah - I noticed another problem.

In the symbol layers box with these patches it only shows the fill, whereas it used to show a preview of the symbol layer.

Sorry, my mistake again - the preview works fine. I must have been testing with symbols larger than the space that the preview fits in.

Please disregard my patch for now. After looking at it again I came to understand how some things were intended to work.

I have made some changes to make the display of selected features in point symbology more consistent with polygon and polyline features, but I'll check them in the next day or so before posting a new patch.

Ah, sorry. That's a long couple of days :(

Please see the new patch. I was hoping to do more to improve the consistency between points, polylines and polygons, but I won't have a chance to do any more for a while.

Hi Alister

Alister Hood wrote:

Here's an updated patch against current master.

it would be better to submit the patch as pull request on github, the are more chances to have it reviewed and committed.

------
I guess this ticket should not be "low" priority. If this functionality is needed for QGIS 2.0 then maybe tickets like this should be "blockers"!

"Blockers" are regressions, so I guess that this could fit. Anyway the list of missing features in new symbology (available in the old one) is quite long, so instead we have wiki page

https://issues.qgis.org/projects/quantum-gis/wiki/Switching_from_Old_to_New_Symbology_and_Labeling/

Has it been decided to retain the old symbology (or just not to implement all the missing features in new symbology) for 2.0.0?
Or has this been shifted to 2.1.0 because it is marked as a feature, but it should be marked as a bug?

Since old symbology was removed, I'm wondering whether this issue will be fixed prior to 2.0 release.

nirvn - wrote:

Since old symbology was removed, I'm wondering whether this issue will be fixed prior to 2.0 release.

missing features in new symbology available in old should be tagged as blockers. The issue is already on the "todo" list

https://issues.qgis.org/wiki/17/Switching_from_Old_to_New_Symbology_and_Labeling

Ummm. Why do you think this is fixed?
As far as I can tell we still have the same situation with fill styles (which Marco says are not actually suitable) available for polygons but not point symbols.
Or did you close it because you really just wanted the ability to have no fill, and you can do this by specifying 0 for the alpha channel?

Oups, Alister's right, this isn't fix; I got confused with the outline style vs fill style.

Could someone re-open this issue? It's a pretty important one.