QGIS » QGIS Application

Replying to [comment:1 brushtyler]:

Should the JPEG quality be enabled only if the "Overviews in TIFF with JPEG compression" is checked, isn't it?

And if the input image is not a GeoTIFF, what happen? We should disable the "Overviews in TIFF..." checkbox in that case.
By testing the input file format, if it's not Erdas Imagine we can disable/enable also the "overview in .aux file".

I think external ovrs are always in a tiff file, that can have a jpeg compression. gdaladdo page states that:
"(...)file with the extension .ovr that is actually in TIFF format"

And an ERDAS file can be created instead. So the option "Overviews in TIFF..." should always be available.
The same would apply to the Erdas option. It should be available regardless of the original's format.

I'm not sure what GDAL does if the original file is a MrSID, ECW or JP2, which have internal overviews already. Can it create external ovrvs? I don't know. Maybe in this case, JPEG compression would not work?

As for the sub-option "JPEG Quality", I think it only makes sense when you choose to create the external ovr with JPEG compression, so it seems correct to me as it is.

We have to mind about this before applying the patch. Your opinions?

I confess I did not try to catch incompatible settings, since GDAL will catch those already and GdalTools reports those errors to the user.

Replying to [comment:2 dcarreira]:

Replying to [comment:1 brushtyler]:

Should the JPEG quality be enabled only if the "Overviews in TIFF with JPEG compression" is checked, isn't it?

And if the input image is not a GeoTIFF, what happen? We should disable the "Overviews in TIFF..." checkbox in that case.
By testing the input file format, if it's not Erdas Imagine we can disable/enable also the "overview in .aux file".

I think external ovrs are always in a tiff file, that can have a jpeg compression. gdaladdo page states that:
"(...)file with the extension .ovr that is actually in TIFF format"

And an ERDAS file can be created instead. So the option "Overviews in TIFF..." should always be available.
The same would apply to the Erdas option. It should be available regardless of the original's format.

I'm not sure what GDAL does if the original file is a MrSID, ECW or JP2, which have internal overviews already. Can it create external ovrvs? I don't know. Maybe in this case, JPEG compression would not work?

As for the sub-option "JPEG Quality", I think it only makes sense when you choose to create the external ovr with JPEG compression, so it seems correct to me as it is.

We have to mind about this before applying the patch. Your opinions?

I confess I did not try to catch incompatible settings, since GDAL will catch those already and GdalTools reports those errors to the user.

Ok, I'm going to apply the patch.

The only change I'm doing is to convert the "overview in TIFF with JPEG..." to a groupbox (see the Translate's creation options) so we avoid to enable/disable the "JPEG Quality" by code.