Bug report #1346
Invalid GetMap Requests in WMS: two question marks
Status: | Closed | ||
---|---|---|---|
Priority: | Low | ||
Assignee: | nobody - | ||
Category: | Web Services clients/WMS | ||
Affected QGIS version: | Regression?: | No | |
Operating System: | Debian | Easy fix?: | No |
Pull Request or Patch supplied: | Resolution: | fixed | |
Crashes QGIS or corrupts data: | Copied to github as #: | 11406 |
Description
I just compiled the latest QGIS trunk version and ran into the problem that the WMS plugin now generates invalid WMS requests. Did someone change the WMS functionality recently?
The problem is that it adds a second question mark in the REQUEST string, although the original connection string already contains a question mark.
Here is my original WMS connection string which works fine for the GetCapabilities request:
http://192.168.0.10/cgi/mapserv?map=/home/mapserverdata/orthofoto_2006.map
Here is the connection string with two question marks that qgis generates:
http://192.168.0.10/cgi/mapserv?map=/home/mapserverdata/orthofoto_2006.map&?SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&BBOX=696445.925470,245312.612036,696779.574530,245536.794214&SRS=EPSG:21781&WIDTH=890&HEIGHT=599&LAYERS=orthofoto_2006_average,orthofoto_2006_bilinear&STYLES=&FORMAT=image/jpeg
Note the second question mark before the SERVICE parameter. I think this is rather simple to fix in the code. Just see if a question mark is already present in the connection string and don't add one if it is.
Thanks for having a look at this bug.
Associated revisions
fix #1346
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@9475 c8812cc2-4d05-0410-92ff-de0c093fc19c
fix #1346
git-svn-id: http://svn.osgeo.org/qgis/trunk@9475 c8812cc2-4d05-0410-92ff-de0c093fc19c
History
#1 Updated by Jürgen Fischer about 16 years ago
- Resolution set to fixed
- Status changed from Open to Closed
fixed in 17c044fc (SVN r9476)
#2 Updated by Andreas Neumann about 16 years ago
wow - this was one of the fastest bug fixes I ever experienced - thank you very much!
#3 Updated by Anonymous about 15 years ago
Milestone Version 1.0.0 deleted